Test fixes for Instance + InstanceTemplate #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
danawillow
approved these changes
Jun 26, 2018
|
@ndmckinley I'm very confused why we aren't putting these files into Chef (we aren't) and I'm even more confused why these tests are passing currently on Chef/Puppet. Any ideas? |
|
Huh! Let's see. |
nat-henderson
approved these changes
Jun 26, 2018
|
We figured out it's because the tests for Chef don't run, and these tests for Puppet were never implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm convinced that there's some broken tests. This should fix them.
[all]
Test fixes for Instance + InstanceTemplate
[terraform]
[puppet]
[puppet-compute]
[puppet-sql]
[puppet-storage]
[chef]
[chef-compute]
[chef-sql]
[chef-storage]
[ansible]